-
savedaws
I am using the GP navigation search (Customizing > Layout > Primary Navigation > Navigation Search > Enable.
However, I am getting the following accessibility error: Elements that act as buttons but use non-button tags (e.g., span, div, a) should include a role=”button” attribute.
on:
<a aria-label="Open Search Bar" href="#" ></a>
How can I fix this? And can this be added as a feature request?
-
Hi there,
The legacy navigation search is deprecated. Can you try using the Navigation search modal instead?
https://docs.generatepress.com/article/navigation-search-modal/#switching-from-navigation-search -
savedaws
As far as I can tell, I am using the current search modal. When I go to Layout > Primary Navigation disable the Navigation Search a new Navigation Search Modal checkbox does NOT magically appear. Even after exit and refresh.
-
Search modal looks like the first image in the article, can you confirm?
https://docs.generatepress.com/article/navigation-search-modal/ -
savedaws
-
Alvind
Hi there,
In Customizer > General, do you see an option to change the site structure from Floats to Flex?
This option only appears on legacy sites built before GP Theme 3.0.Switching to Flex updates the theme to use modern templates, which include additional hooks—such as the one required for the Modal.
Note: Switching to Flex is a one-way change—you won’t be able to revert it. Issues from this switch are rare, but for peace of mind, we recommend creating a backup or testing the change on a staging site first.
-
savedaws
Yes, the theme was in Floats and not Flex. However, after switching and returning to Navigation Search, disabling it does not display the option for the new module. I did try purging my browser cache and going back in.
Another issue, once updating to Flex, the .menu-item-float-right class that I had on 3 of 11 menu items no longer seems to be working. So troubleshooting that now too.
-
Alvind
If you need us to take a closer look at the issue, feel free to provide a site link so we can inspect it further.
-
savedaws
adding info to PI
-
Under customizer > general, is the icon type set to font or svg?
If it’s font, set it to SVG.
-
savedaws
Setting it to SVG fixed the search in nav issue.
However, do you have updated CSS classes for aligning a selection of menu items right in an overall left-aligning menu?
-
Something like example 3?https://docs.generatepress.com/article/header-examples/#example-3
If not, can you provide a mockup of what you want to achieve?
-
savedaws
You can see it in action on https://smithrockclimbing.com/ and that is how https://timberlinemtguides.com/ header used to look until I updated it to flex.
-
I see, try this:
@media(min-width: 1161px) { .main-navigation .main-nav>ul { width: 100%; justify-content: space-between; } div#primary-menu { flex-grow: 1; } .main-navigation .main-nav > ul >li:nth-child(5) { margin-right: auto; } }
-
savedaws
That worked, thank you.
-
No Problem 🙂
- You must be logged in to reply to this topic.