-
I’ve increased the max input vars to 4000 and the memory limit to 512M on both dev and live sites. Unfortunately the editor styles are still missing.
-
Hmmm…. ok, what happens if you temporarily switch to a different theme ? eg. Twenty21 – does the editor style display correctly then?
-
The editor styles display correctly when using another theme. As in, they stay the same before/after deactivating GB. So could this be a conflict between GB 1.9 and my theme (Bricks Builder)?
-
Hi there,
It does seem like a conflict, but Bricks should not interfere with the styling inside the editor.
-
I’m not convinced Bricks is causing the problem. GB 1.8.3 worked fine with Bricks. What do you suggest?
-
I’ve installed GB 1.9 and Bricks on a clean WP install, without anything else and the same issue occurs. No styling in the editor. So there’s definitely a conflict of some kind between Bricks and the latest GB 1.9 update.
-
We’re doing some internal testing to see whats going on here, we will come back to you asap.
-
Ok, so we tracked this down to this filter we added to the GenerateBlocks plugin:
Which is just a CSS reset that GB requires to remove the editor margins from our blocks.
The
block_editor_settings_allfilter we are using is a core filter hook that is built for this kind of thing, and we use this throughout GP and GB with no previous issues.Now, we looked inside the Bricks theme to see if it was using that same filter hook and if there was any possible cause for conflict. What we discoverd is they do not use that filter.
So we are not sure how they are inserting their code in the editor and therefore completely at a loss of how this filter in GB would affect that.For reference we have a GitIssue on GB plugin open here:
https://github.com/tomusborne/generateblocks/issues/1232#issuecomment-2079578628
Could you raise a support topic with Bricks to see if they can shed some light on this ?
-
Hi! I just wanted to jump back in and note again that this is also happening with the Trellis framework and GB.
Assuming the same new filter GB added in this update is affecting Trellis, too, if it’s helpful, Trellis has not been updated in almost a year, so I don’t know why this filter would suddenly affect the editor now and not previously.
-
You can check if it is the issue by removing the filter using this PHP Snippet:
remove_filter( 'block_editor_settings_all', 'generateblocks_do_block_css_reset', 15 );To note: WP 6.5 introduced some changes as to how it parses CSS added via the
block_editor_settings_alland how it determines whether to prefix the CSS with theeditor-styles-wrapperclass, which may be the actual issue. -
You can check if it is the issue by removing the filter using this PHP Snippet:
remove_filter( ‘block_editor_settings_all’, ‘generateblocks_do_block_css_reset’, 15 );
Thanks—that fixed it immediately!
-
Good to hear that. I wonder what method they are using to load editor styles ? Presumably a similar method to Bricks.
-
I’m not sure how Trellis does that, but in case it’s at all helpful, I think it may be in this file, inc/classes/class-admin.php:
-
Looks like it’s using a regular enqueue which isn’t “the” official way of adding editor styles since version 6.0. But I can’t see why GB hooking the core
block_editor_settings_allwould affect that… but thanks for sharing that, we’ll continue our investigations. -
Could you raise a support topic with Bricks to see if they can shed some light on this ?
Thanks for looking into it, I’ll contact Bricks support tomorrow and report back once they have something.
-
Thanks!
- You must be logged in to reply to this topic.